feat: ICertifiableV1 interface for OffchainAssetReceiptVault.isCertificationExpired()#295
Merged
thedavidmeister merged 1 commit intomainfrom May 1, 2026
Merged
Conversation
…icationExpired() Adds a read-only interface exposing the `isCertificationExpired()` getter on contracts gated by a certifier-set expiry timestamp. `OffchainAssetReceiptVault` already had the getter; now inherits the interface so downstream consumers can read certification state through a typed import without pulling in the concrete contract. Mirrors the IAuthorizableV1 pattern from #293. Closes #294. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughA new interface Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
This was referenced May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
src/interface/ICertifiableV1.sol— a minimal read-only interface exposing theisCertificationExpired()getter on contracts gated by a certifier-set expiry timestamp.OffchainAssetReceiptVaultalready had the getter; it now inherits the interface so downstream consumers can read certification state through a typed import without depending on the concrete vault contract.Mirrors the IAuthorizableV1 pattern from #293.
Closes #294.
Test plan
forge buildcleanSummary by CodeRabbit