add V1 and V2 interfaces for deployers and oracles

[thedavidmeister]

Summary

• Add V1 interfaces with original I_ getter names matching deployed on-chain ABIs
• Add V2 interfaces with new camelCase i getter names for new deployments
• Covers: OARV beacon set deployer, ERC20 clone deployer, PythOracle, FtsoV2LTSFeedOracle

Downstream consumers (st0x.deploy) need V1 interfaces for fork tests against existing deployments and V2 for new code.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features
  • Added new contract interfaces enabling deployment and configuration of receipt vaults and oracle systems with support for multiple implementation versions.

[coderabbitai]

Warning

Rate limit exceeded

@thedavidmeister has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 30 minutes and 57 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 30 minutes and 57 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 45dc7376-8db2-4c6c-a012-32758409e8a7

📥 Commits

Reviewing files that changed from the base of the PR and between 75715b7 and 3530b55.

📒 Files selected for processing (12)

• src/concrete/deploy/ERC20PriceOracleReceiptVaultCloneDeployer.sol
• src/concrete/deploy/OffchainAssetReceiptVaultBeaconSetDeployer.sol
• src/interface/IERC20PriceOracleReceiptVaultCloneDeployerV1.sol
• src/interface/IFtsoV2LTSFeedOracleV1.sol
• src/interface/IOffchainAssetReceiptVaultBeaconSetDeployerV1.sol
• src/interface/IOffchainAssetReceiptVaultBeaconSetDeployerV2.sol
• src/interface/IPythOracleV1.sol
• test/src/concrete/deploy/ERC20PriceOracleReceiptVaultCloneDeployer.construct.t.sol
• test/src/concrete/deploy/ERC20PriceOracleReceiptVaultCloneDeployer.ierc165.t.sol
• test/src/concrete/deploy/OffchainAssetReceiptVaultBeaconSetDeployer.construct.t.sol
• test/src/concrete/deploy/OffchainAssetReceiptVaultBeaconSetDeployer.ierc165.t.sol
• test/src/concrete/oracle/PythOracle.t.sol

Walkthrough

This pull request introduces eight new Solidity interface files that standardize the ABIs for vault deployers and oracle contracts. The interfaces are organized in V1 and V2 pairs, where V1 uses uppercase function naming conventions (e.g., I_RECEIPT_IMPLEMENTATION()) and V2 uses camelCase conventions (e.g., iReceiptImplementation()). The interfaces cover ERC20 Price Oracle Receipt Vault clone deployers, FTSO V2 LTS Feed Oracles, Offchain Asset Receipt Vault beacon set deployers, and Pyth Oracles.

Changes

Cohort / File(s)	Summary
ERC20 Price Oracle Receipt Vault Clone Deployers src/interface/IERC20PriceOracleReceiptVaultCloneDeployerV1.sol, src/interface/IERC20PriceOracleReceiptVaultCloneDeployerV2.sol	Added V1 and V2 interfaces with function accessors for receipt and vault implementations, and a newERC20PriceOracleReceiptVault() deployment function accepting ERC20PriceOracleReceiptVaultConfigV2 configuration.
FTSO V2 LTS Feed Oracle Interfaces src/interface/IFtsoV2LTSFeedOracleV1.sol, src/interface/IFtsoV2LTSFeedOracleV2.sol	Added V1 and V2 interfaces defining feedId() and staleAfter() view functions returning bytes21 and uint256 respectively.
Offchain Asset Receipt Vault Beacon Set Deployers src/interface/IOffchainAssetReceiptVaultBeaconSetDeployerV1.sol, src/interface/IOffchainAssetReceiptVaultBeaconSetDeployerV2.sol	Added V1 and V2 interfaces exposing beacon accessors for receipt and vault implementations, and a newOffchainAssetReceiptVault() deployment function accepting OffchainAssetReceiptVaultConfigV2 configuration.
Pyth Oracle Interfaces src/interface/IPythOracleV1.sol, src/interface/IPythOracleV2.sol	Added V1 and V2 interfaces defining price feed ID, stale after duration, and Pyth contract reference view functions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change—adding V1 and V2 interface variants for deployers and oracles across four contracts.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch deployer-interfaces

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/interface/IOffchainAssetReceiptVaultBeaconSetDeployerV1.sol`:
- Around line 6-8: The interface is importing OffchainAssetReceiptVaultConfigV2
transitively from OffchainAssetReceiptVaultBeaconSetDeployer.sol; change the
import to pull OffchainAssetReceiptVaultConfigV2 directly from the vault module
where it is defined (OffchainAssetReceiptVault.sol) so the interface imports
only OffchainAssetReceiptVault and OffchainAssetReceiptVaultConfigV2 from the
concrete vault file; update the import statement referencing
OffchainAssetReceiptVaultConfigV2 accordingly in
IOffchainAssetReceiptVaultBeaconSetDeployerV1.

In `@src/interface/IOffchainAssetReceiptVaultBeaconSetDeployerV2.sol`:
- Around line 6-8: Replace the transitive import of
OffchainAssetReceiptVaultConfigV2 from
OffchainAssetReceiptVaultBeaconSetDeployer.sol with a direct import from the
vault module where the type is defined (OffchainAssetReceiptVault.sol); update
the import statement in IOffchainAssetReceiptVaultBeaconSetDeployerV2 to
reference OffchainAssetReceiptVault.sol so OffchainAssetReceiptVaultConfigV2 is
imported directly and removes the unnecessary coupling through
OffchainAssetReceiptVaultBeaconSetDeployer.sol.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: e2afab0e-09dd-43bf-85f3-8fc27336a9a6

📥 Commits

Reviewing files that changed from the base of the PR and between e871aad and 75715b7.

📒 Files selected for processing (8)

• src/interface/IERC20PriceOracleReceiptVaultCloneDeployerV1.sol
• src/interface/IERC20PriceOracleReceiptVaultCloneDeployerV2.sol
• src/interface/IFtsoV2LTSFeedOracleV1.sol
• src/interface/IFtsoV2LTSFeedOracleV2.sol
• src/interface/IOffchainAssetReceiptVaultBeaconSetDeployerV1.sol
• src/interface/IOffchainAssetReceiptVaultBeaconSetDeployerV2.sol
• src/interface/IPythOracleV1.sol
• src/interface/IPythOracleV2.sol