Skip to content

fix: use withdraw4 for Orderbook V6 in intra-orderbook calldata #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Siddharth2207 wants to merge 2 commits into
base: 2026-02-12-sushi-price-impact
Choose a base branch
from
Open

fix: use withdraw4 for Orderbook V6 in intra-orderbook calldata #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b57c615
fix: use withdraw4 for Orderbook V6 in intra-orderbook calldata
Siddharth2207 Mar 27, 2026
a31dd44
bump sushiswap submodule to add cbBTC to Base routing bases
Siddharth2207 Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/sushiswap
Open in desktop
Submodule sushiswap updated 1 files
+7 −0 packages/sushi/src/config/bases-to-check-trades-against.ts
62 changes: 61 additions & 1 deletion src/core/modes/intra/simulation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,65 @@ export class IntraOrderbookTradeSimulator extends TradeSimulatorBase {
}

/**
* Builds the calldata for v4 order
* Builds the calldata for v4 order on Orderbook V6
* @param task - The ensure withdraw bounty task object
*/
getCalldataForV4OrderV6(task: TaskType): `0x${string}` {
const withdrawInputCalldata = encodeFunctionData({
abi: ABI.Orderbook.V6.Primary.Orderbook,
functionName: "withdraw4",
args: [
this.tradeArgs.orderDetails.buyToken,
this.inputBountyVaultId,
maxFloat(this.tradeArgs.orderDetails.buyTokenDecimals),
[],
],
});
const withdrawOutputCalldata = encodeFunctionData({
abi: ABI.Orderbook.V6.Primary.Orderbook,
functionName: "withdraw4",
args: [
this.tradeArgs.orderDetails.sellToken,
this.outputBountyVaultId,
maxFloat(this.tradeArgs.orderDetails.sellTokenDecimals),
this.tradeArgs.solver.appOptions.gasCoveragePercentage === "0" ? [] : [task],
],
});
const clear3Calldata = encodeFunctionData({
abi: ABI.Orderbook.V6.Primary.Orderbook,
functionName: "clear3",
args: [
this.tradeArgs.orderDetails.takeOrder.struct.order,
this.tradeArgs.counterpartyOrderDetails.struct.order,
{
aliceInputIOIndex: BigInt(
this.tradeArgs.orderDetails.takeOrder.struct.inputIOIndex,
),
aliceOutputIOIndex: BigInt(
this.tradeArgs.orderDetails.takeOrder.struct.outputIOIndex,
),
bobInputIOIndex: BigInt(
this.tradeArgs.counterpartyOrderDetails.struct.inputIOIndex,
),
bobOutputIOIndex: BigInt(
this.tradeArgs.counterpartyOrderDetails.struct.outputIOIndex,
),
aliceBountyVaultId: this.inputBountyVaultId,
bobBountyVaultId: this.outputBountyVaultId,
},
[],
[],
],
});
return encodeFunctionData({
abi: ABI.Orderbook.V6.Primary.Orderbook,
functionName: "multicall",
args: [[clear3Calldata, withdrawInputCalldata, withdrawOutputCalldata]],
});
}

/**
* Builds the calldata for v4 order on Orderbook V5
* @param task - The ensure withdraw bounty task object
*/
getCalldataForV4Order(task: TaskType): `0x${string}` {
Expand Down Expand Up @@ -329,6 +387,8 @@ export class IntraOrderbookTradeSimulator extends TradeSimulatorBase {
getCalldata(task: TaskType): `0x${string}` {
if (Pair.isV3(this.tradeArgs.orderDetails)) {
return this.getCalldataForV3Order(task);
} else if (Pair.isV4OrderbookV6(this.tradeArgs.orderDetails)) {
return this.getCalldataForV4OrderV6(task);
} else {
return this.getCalldataForV4Order(task);
}
Expand Down
Loading