suites#157
Merged
thedavidmeister merged 3 commits intomainfrom Oct 11, 2025
Merged
Conversation
Contributor
WalkthroughAdds deployment-suite constants and environment-based selection to Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Env as ENV
participant Deploy as Deploy.sol
participant Tables as container.writeZoltu()
participant Contract as LibDecimalFloatDeploy.decimalFloatZoltu()
Note over Deploy: Initialization
Env->>Deploy: DEPLOYMENT_SUITE (default "all")
Deploy->>Deploy: suite = keccak256(DEPLOYMENT_SUITE)
alt suite == ALL or TABLES
Deploy->>Tables: writeZoltu()
Tables-->>Deploy: done
else
Note over Deploy: Skip tables
end
alt suite == ALL or CONTRACT
Deploy->>Contract: decimalFloatZoltu()
Contract-->>Deploy: done
else
Note over Deploy: Skip contract
end
Note over Deploy: Deployment complete
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
script/Deploy.sol(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: rainix (macos-latest, rainix-rs-test)
- GitHub Check: rainix (macos-latest, rainix-sol-legal)
🔇 Additional comments (1)
script/Deploy.sol (1)
25-31: Conditional logic structure is correct.The conditional deployment logic correctly handles selective execution:
- Tables deploy when suite is ALL or TABLES
- Contract deploys when suite is ALL or CONTRACT
- The "ALL" case properly triggers both deployments
However, this logic inherits the critical constant mismatch issue flagged above. Once the constants are fixed to match expected user inputs and validation is added, this implementation will work correctly.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/manual-sol-artifacts.yaml(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: thedavidmeister
PR: rainlanguage/rain.math.float#157
File: script/Deploy.sol:9-11
Timestamp: 2025-10-11T14:36:29.947Z
Learning: In script/Deploy.sol for the rain.math.float repository, the DEPLOYMENT_SUITE constants use full qualified dotted notation (e.g., "deployment.suite.tables", "deployment.suite.contract") intentionally. Users select deployment options by setting the DEPLOYMENT_SUITE environment variable to these exact strings, not shortened versions like "tables" or "contract".
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: rainix (ubuntu-latest, test-wasm-build)
- GitHub Check: rainix (ubuntu-latest, rainix-sol-test)
- GitHub Check: rainix (ubuntu-latest, rainix-rs-static)
- GitHub Check: rainix (ubuntu-latest, rainix-sol-static)
- GitHub Check: rainix (macos-latest, rainix-sol-legal)
- GitHub Check: rainix (macos-latest, rainix-rs-test)
- GitHub Check: rainix (ubuntu-latest, rainix-rs-test)
- GitHub Check: rainix (ubuntu-latest, rainix-sol-legal)
- GitHub Check: git-clean
|
@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment: S/M/L PR Classification Guidelines:This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed. Small (S)Characteristics:
Review Effort: Would have taken 5-10 minutes Examples:
Medium (M)Characteristics:
Review Effort: Would have taken 15-30 minutes Examples:
Large (L)Characteristics:
Review Effort: Would have taken 45+ minutes Examples:
Additional Factors to ConsiderWhen deciding between sizes, also consider:
Notes:
|
Contributor
|
Tip For best results, initiate chat on the files or code changes. SIZE=M |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
Checks
By submitting this for review, I'm confirming I've done the following:
Summary by CodeRabbit