Skip to content

fix nix ci #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thedavidmeister merged 12 commits into from
May 29, 2025
Merged

fix nix ci #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7677c74
fix nix ci
thedavidmeister May 28, 2025
818e2c0
update flake
thedavidmeister May 28, 2025
e0d881e
evm version
thedavidmeister May 28, 2025
df9a84b
forge
thedavidmeister May 28, 2025
3a16196
intorastring
thedavidmeister May 28, 2025
4df31dd
update hash
thedavidmeister May 28, 2025
240a621
update typecast
thedavidmeister May 29, 2025
795686a
update rain math binary
thedavidmeister May 29, 2025
e823ac0
update float
thedavidmeister May 29, 2025
edf7371
update float
thedavidmeister May 29, 2025
30a6874
codegen
thedavidmeister May 29, 2025
7541b67
solmem
thedavidmeister May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions .github/workflows/rainix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,22 @@ jobs:
submodules: recursive
fetch-depth: 0

- uses: DeterminateSystems/nix-installer-action@v4
- uses: DeterminateSystems/magic-nix-cache-action@v2
- uses: nixbuild/nix-quick-install-action@v30
with:
nix_conf: |
keep-env-derivations = true
keep-outputs = true
Comment on lines +20 to +24
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Name the Nix installation step for clarity
Adding an explicit name field improves readability and debugging in CI logs.

-      - uses: nixbuild/nix-quick-install-action@v30
-        with:
+      - name: Setup Nix (nix-quick-install)
+        uses: nixbuild/nix-quick-install-action@v30
+        with:
           nix_conf: |
             keep-env-derivations = true
             keep-outputs = true
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- uses: nixbuild/nix-quick-install-action@v30
with:
nix_conf: |
keep-env-derivations = true
keep-outputs = true
- name: Setup Nix (nix-quick-install)
uses: nixbuild/nix-quick-install-action@v30
with:
nix_conf: |
keep-env-derivations = true
keep-outputs = true
🤖 Prompt for AI Agents 
In .github/workflows/rainix.yaml around lines 20 to 24, the Nix installation
step lacks a descriptive name, which reduces clarity in CI logs. Add a `name`
field to this step with a clear and concise description, such as "Install Nix
with quick-install-action," to improve readability and ease debugging.

- name: Restore and save Nix store
uses: nix-community/cache-nix-action@v6
with:
# restore and save a cache using this key
primary-key: nix-${{ runner.os }}-${{ hashFiles('**/*.nix', '**/flake.lock') }}
# if there's no cache hit, restore a cache by this prefix
restore-prefixes-first-match: nix-${{ runner.os }}-
# collect garbage until the Nix store size (in bytes) is at most this number
# before trying to save a new cache
# 1G = 1073741824
gc-max-store-size-linux: 1G

- run: nix develop --command rainix-sol-prelude
- name: Run ${{ matrix.task }}
Expand Down
67 changes: 33 additions & 34 deletions flake.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions foundry.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ solc = "0.8.25"
optimizer = true
optimizer_runs = 1000000

evm_version = "paris"

bytecode_hash = "none"
cbor_metadata = false

Expand Down
2 changes: 1 addition & 1 deletion lib/forge-std
Open in desktop
Submodule forge-std updated 34 files
+193 −0 CONTRIBUTING.md
+18 −2 README.md
+3 −1 foundry.toml
+1 −1 package.json
+12 −1 scripts/vm.py
+16 −9 src/Base.sol
+1 −0 src/Script.sol
+26 −3 src/StdChains.sol
+14 −2 src/StdCheats.sol
+30 −0 src/StdConstants.sol
+0 −17 src/StdUtils.sol
+1 −0 src/Test.sol
+470 −24 src/Vm.sol
+1 −1 src/interfaces/IERC1155.sol
+1 −1 src/interfaces/IERC4626.sol
+72 −0 src/interfaces/IERC6909.sol
+1 −1 src/interfaces/IERC721.sol
+150 −0 src/interfaces/IERC7540.sol
+241 −0 src/interfaces/IERC7575.sol
+0 −234 src/mocks/MockERC20.sol
+0 −231 src/mocks/MockERC721.sol
+44 −0 test/CommonBase.t.sol
+0 −4 test/StdAssertions.t.sol
+7 −8 test/StdChains.t.sol
+45 −24 test/StdCheats.t.sol
+38 −0 test/StdConstants.t.sol
+20 −3 test/StdStorage.t.sol
+2 −2 test/Vm.t.sol
+1 −1 test/compilation/CompilationScript.sol
+1 −1 test/compilation/CompilationScriptBase.sol
+1 −1 test/compilation/CompilationTest.sol
+1 −1 test/compilation/CompilationTestBase.sol
+0 −441 test/mocks/MockERC20.t.sol
+0 −721 test/mocks/MockERC721.t.sol
2 changes: 1 addition & 1 deletion lib/rain.intorastring
Open in desktop
Submodule rain.intorastring updated 5 files
+16 −2 .github/workflows/rainix.yaml
+33 −34 flake.lock
+2 −0 foundry.toml
+1 −1 lib/forge-std
+1 −1 lib/rain.solmem
2 changes: 1 addition & 1 deletion lib/rain.lib.hash
Open in desktop
Submodule rain.lib.hash updated 4 files
+16 −2 .github/workflows/rainix.yaml
+33 −34 flake.lock
+1 −0 foundry.toml
+1 −1 lib/forge-std
2 changes: 1 addition & 1 deletion lib/rain.lib.typecast
Open in desktop
Submodule rain.lib.typecast updated 4 files
+16 −2 .github/workflows/rainix.yaml
+33 −34 flake.lock
+2 −0 foundry.toml
+1 −1 lib/forge-std
2 changes: 1 addition & 1 deletion lib/rain.math.binary
Open in desktop
Submodule rain.math.binary updated 4 files
+16 −2 .github/workflows/rainix.yaml
+33 −34 flake.lock
+2 −0 foundry.toml
+1 −1 lib/forge-std
2 changes: 1 addition & 1 deletion lib/rain.math.float
Open in desktop
Submodule rain.math.float updated 50 files
+227 −204 .gas-snapshot
+16 −2 .github/workflows/git-clean.yaml
+16 −2 .github/workflows/manual-sol-artifacts.yaml
+16 −2 .github/workflows/rainix.yaml
+43 −65 flake.lock
+1 −1 foundry.toml
+1 −1 lib/forge-std
+1 −1 lib/rain.datacontract
+1 −1 lib/rain.math.fixedpoint
+1 −1 lib/rain.sol.codegen
+1 −1 lib/rain.string
+3 −1 script/Deploy.sol
+166 −0 src/concrete/DecimalFloat.sol
+28 −14 src/lib/LibDecimalFloat.sol
+18 −1 src/lib/deploy/LibDecimalFloatDeploy.sol
+9 −25 src/lib/implementation/LibDecimalFloatImplementation.sol
+1 −1 test/abstract/LogTest.sol
+2 −2 test/lib/LibDecimalFloatSlow.sol
+27 −0 test/src/concrete/DecimalFloat.abs.t.sol
+27 −0 test/src/concrete/DecimalFloat.add.t.sol
+27 −0 test/src/concrete/DecimalFloat.div.t.sol
+27 −0 test/src/concrete/DecimalFloat.eq.t.sol
+27 −0 test/src/concrete/DecimalFloat.floor.t.sol
+28 −0 test/src/concrete/DecimalFloat.format.t.sol
+27 −0 test/src/concrete/DecimalFloat.frac.t.sol
+27 −0 test/src/concrete/DecimalFloat.gt.t.sol
+27 −0 test/src/concrete/DecimalFloat.inv.t.sol
+27 −0 test/src/concrete/DecimalFloat.isZero.t.sol
+27 −0 test/src/concrete/DecimalFloat.log10.t.sol
+27 −0 test/src/concrete/DecimalFloat.lt.t.sol
+27 −0 test/src/concrete/DecimalFloat.max.t.sol
+27 −0 test/src/concrete/DecimalFloat.min.t.sol
+27 −0 test/src/concrete/DecimalFloat.minus.t.sol
+27 −0 test/src/concrete/DecimalFloat.mul.t.sol
+29 −0 test/src/concrete/DecimalFloat.parse.t.sol
+27 −0 test/src/concrete/DecimalFloat.pow.t.sol
+27 −0 test/src/concrete/DecimalFloat.pow10.t.sol
+27 −0 test/src/concrete/DecimalFloat.sub.t.sol
+3 −2 test/src/lib/LibDecimalFloat.decimal.t.sol
+1 −1 test/src/lib/LibDecimalFloat.decimalLossless.t.sol
+9 −11 test/src/lib/LibDecimalFloat.div.t.sol
+44 −0 test/src/lib/LibDecimalFloat.isZero.t.sol
+3 −3 test/src/lib/LibDecimalFloat.mixed.t.sol
+10 −11 test/src/lib/LibDecimalFloat.mul.t.sol
+16 −16 test/src/lib/LibDecimalFloat.pow.t.sol
+10 −10 test/src/lib/LibDecimalFloat.pow10.t.sol
+34 −34 test/src/lib/implementation/LibDecimalFloatImplementation.div.t.sol
+24 −24 test/src/lib/implementation/LibDecimalFloatImplementation.mul.t.sol
+25 −25 test/src/lib/implementation/LibDecimalFloatImplementation.pow10.t.sol
+10 −2 test/src/lib/implementation/LibDecimalFloatImplementation.withTargetExponent.t.sol
2 changes: 1 addition & 1 deletion lib/rain.sol.codegen
Open in desktop
Submodule rain.sol.codegen updated 6 files
+16 −2 .github/workflows/git-clean.yaml
+16 −2 .github/workflows/rainix.yaml
+33 −34 flake.lock
+2 −0 foundry.toml
+1 −1 lib/forge-std
+1 −1 lib/rain.math.binary
2 changes: 1 addition & 1 deletion lib/rain.solmem
Open in desktop
Submodule rain.solmem updated 10 files
+16 −2 .github/workflows/rainix.yaml
+0 −1 .gitmodules
+33 −34 flake.lock
+1 −0 foundry.toml
+1 −1 lib/forge-std
+6 −1 test/src/lib/LibBytes.t.sol
+6 −1 test/src/lib/LibBytes32Array.truncate.t.sol
+5 −1 test/src/lib/LibStackPointer.toIndexSigned.t.sol
+38 −22 test/src/lib/LibStackSentinel.t.sol
+6 −1 test/src/lib/LibUint256Array.truncate.t.sol