conformance: map signal step to public track_signal API (DEV-1201) - #18
Merged
Conversation
Co-Authored-By: bot_apk <apk@cognition.ai>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
pavel-y-ivanov
approved these changes
Jul 14, 2026
pavel-y-ivanov
left a comment
Contributor
There was a problem hiding this comment.
DEV-1201 pt3: signal step via public track_signal, conformance-only. CI green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harness PR #47 activated the
signalcapability + added two experimental signal scenarios. This maps the harnesssignalstep onto the Rust SDK's public signal surface and bumps the pinned harness ref. Driver-only; no SDK behavior change.The SDK already exposes public
Client::track_signal(Signal)(withSignal/SignalKindre-exported from the crate root), shippingevent_id/signal_name/signal_typetosignals/trackwithsignal_typedefaulting to"default". The driver'ssignalstep was previously reported unsupported (exit 3); it is now implemented.conformance/src/main.rs: addsignaltoCAPABILITIES, add"signal" => step_signaldispatch arm (drops it from the unsupported fallthrough), addstep_signal()mapping the step args ontoSignal { event_id, name, kind←signal_type, sentiment, timestamp, properties, attachment_id, comment, after }..github/workflows/conformance.yml:HARNESS_REF→cf744e9(harness main, DEV-1201).event_id/nameare required (required_str); the rest map via the existingoptional_str/properties/timestamphelpers, matching how the other steps are wired.Verified locally (toolchain matching MSRV/stable):
cargo build --manifest-path conformance/Cargo.tomlclean,cargo fmt --checkclean. Fault lane against the bumped corpus:signal-request-shape@fault→ pass, runner exit 0.conformance/failures.txtunchanged — the other four experimental scenarios (hang-request-deadline,reconnect-identical-body,retry-500-then-200,retry-after-cap) arestatus: experimental(report-only) pre-existing gaps and do not gate.Link to Devin session: https://app.devin.ai/sessions/c59705fa818b4a9ca7c51a24480064b1
Note
Low Risk
Changes are limited to the conformance driver and CI harness pin; production SDK code is untouched.
Overview
The conformance driver now advertises and implements the harness
signalcapability instead of returning unsupported (exit 3). Harness scenarios that requiresignalcan run against this SDK.step_signalmaps harness args onto publicClient::track_signal(event_id,name, optionalsignal_type→kind, plus sentiment, timestamp, properties, attachment_id, comment, after). CI bumps the pinned raindrop-sdk-harness ref to the commit that activates signal scenarios.No SDK behavior change — only the standalone conformance driver and workflow pin.
Reviewed by Cursor Bugbot for commit 6d0a0df. Bugbot is set up for automated code reviews on this repo. Configure here.