This repository was archived by the owner on Aug 17, 2017. It is now read-only.
allow optional inclusion in some controllers + update readme#197
Open
razum2um wants to merge 1 commit intorails:masterfrom
Open
allow optional inclusion in some controllers + update readme#197razum2um wants to merge 1 commit intorails:masterfrom
razum2um wants to merge 1 commit intorails:masterfrom
Conversation
|
👍 Will this be considered for merge? If so I'll take a stab at fixing tests. |
Author
|
rebased on master with deleted Gemfile.lock |
|
thanks @razum2um |
This was referenced Sep 10, 2014
|
Can we merge this into master branch? It is a such important feature. |
Author
|
@jackwu-figured - thanks for reminder, I rebased it on master again |
|
@bump please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've recently got a big legacy codebase, which I intend to upgrade, so this is quite inconvenient not to be able to include these gem only to some controllers.
I've also got use of #144 conserning ActiveSupport.on_load