Add Ruby 4 to tests and stop using minitest/mock for stub
#697
+20
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason this stopped working in CI and we don't really need it. I'm not sure why we did it in this way instead of using `mocha` ^_^U Rails still requires it, so let's make sure it's loaded in the test_helper.
rosa
force-pushed
the
fix-ci
branch
2 times, most recently
from
a988bf2 to
c181953
Compare
And minitest 6.x requires Ruby 3.2+
rosa
force-pushed
the
fix-ci
branch
2 times, most recently
from
619b880 to
b0c9814
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why we did it in this way instead of using
mocha😅This also avoids
minitest 6.xbecause it requires Ruby 3.2, and this still supports Ruby 3.1.