Repository navigation
build: drop oldest-supported-numpy from build requirements - #286
Merged
Merged
Conversation
The package is pure Python, so numpy is not needed to build it, and numpy has deprecated oldest-supported-numpy. Build tools that do not install arbitrary build requirements (for example rules_py's uv sdist builder) fail on it.
taughz
force-pushed
the
build/drop-oldest-supported-numpy
branch
from
November 5, 2026 15:04
6930962 to
8eb0e3b
Compare
taughz
added a commit
that referenced
this pull request
Nov 5, 2026
17 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyproject.tomllistsoldest-supported-numpyas a build requirement. spatialmath is pure Python (no extension modules, nosetup.py), so numpy is not needed at build time. numpy has also deprecatedoldest-supported-numpy.Build tools that only install the build backend fail on it. One example is rules_py's uv sdist builder, which fails with
Unmet dependencies: oldest-supported-numpywhen building spatialmath from a source archive. This PR leavesrequires = ["setuptools"].Testing
pyproject-build(isolated) builds the sdist and the wheel.METADATAare identical to a wheel built frommaster.