Skip to content

fix(typing): add missing @classmethod to SE3.Eul, SE3.RPY, SE3.Trans overloads #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
filipjsowa wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(typing): add missing @classmethod to SE3.Eul, SE3.RPY, SE3.Trans overloads #283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions spatialmath/pose3d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1685,10 +1685,12 @@ def Rand(
)

@overload
@classmethod
def Eul(cls, phi: float, theta: float, psi: float, unit: str = "rad") -> SE3:
...

@overload
@classmethod
def Eul(cls, angles: ArrayLike3, unit: str = "rad") -> SE3:
...

Expand Down Expand Up @@ -1735,10 +1737,12 @@ def Eul(cls, *angles, unit="rad") -> SE3:
return cls([smb.eul2tr(a, unit=unit) for a in angles], check=False)

@overload
@classmethod
def RPY(cls, roll: float, pitch: float, yaw: float, unit: str = "rad") -> SE3:
...

@overload
@classmethod
def RPY(cls, angles: ArrayLike3, unit: str = "rad") -> SE3:
...

Expand Down Expand Up @@ -1985,10 +1989,12 @@ def Delta(cls, d: ArrayLike6) -> SE3:
return cls(smb.trnorm(smb.delta2tr(d)))

@overload
@classmethod
def Trans(cls, x: float, y: float, z: float) -> SE3:
...

@overload
@classmethod
def Trans(cls, xyz: ArrayLike3) -> SE3:
...

Expand Down
Loading