Repository navigation
Fix intersection of three planes - #279
Merged
taughz merged 2 commits intoNov 5, 2026
Merged
Conversation
taughz
approved these changes
Nov 5, 2026
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Avoids a textual conflict with other PRs that add tests after the line distance tests, and restores the executable bit on the test file, which runs as a script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plane3.intersectionraises a matrix multiplication error even for three planes with a unique intersection:np.linalg.det(A)is a scalar. SolveA @ point = -binstead, following the documented plane equationn @ point + d = 0.Reproduction on the base revision:
Validation on Windows / Python 3.11:
pytest tests/test_geom3d.py -q: 56 passed.pytest -q: 487 passed, 3 skipped; 63 subtests passed.git diff --checkpassed.Tests cover known intersections, oblique normals, signed coefficient scaling, plane order, equation residuals, and singular systems. No dependencies or public signatures change.
The human requested a robotics-related bug fix and authorized submission. Codex diagnosed the problem, implemented the one-line fix, and wrote and ran the tests.