OpenAPI: support optional attributes and Array<> syntax in inline sch…#228
Open
ayushman1210 wants to merge 2 commits intorage-rb:mainfrom
Open
OpenAPI: support optional attributes and Array<> syntax in inline sch…#228ayushman1210 wants to merge 2 commits intorage-rb:mainfrom
ayushman1210 wants to merge 2 commits intorage-rb:mainfrom
Conversation
Author
|
Hi @rsamoilov please review this pr when you have some free time and let me know if anything else needed |
rsamoilov
reviewed
Mar 6, 2026
Member
rsamoilov
left a comment
There was a problem hiding this comment.
Left one small comment. Otherwise, looks good 👍
rsamoilov
reviewed
Mar 9, 2026
Member
rsamoilov
left a comment
There was a problem hiding this comment.
This looks good. The only thing is that this doesn't seem to support enums. For example, the [IN_PROGRESS, COMPLETED] expression creates an enum, but Array<IN_PROGRESS, COMPLETED> is not parsed correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two limitations in the inline YAML schema parser used for @request and @response tags, as described in the issue
2.Array<> Syntax Support: Added support for the Array syntax inside inline schemas to provide a consistent alternative to the unary array [Type] syntax.
Changes
File --> lib/rage/openapi/parsers/yaml.rb
File --> spec/openapi/parsers/yaml_spec.rb
Verification
Fixes #227