fix(cli): voyage-handoff uses correct tmux session names - #169
Merged
Conversation
…ge- prefixed feature names
- formatHandoffBlock prefixes session with voyage-<name> for string inputs;
accepts {voyage, session} objects for explicit override
- voyage-handoff gains --session <name> flag for custom tmux session names
- validateName rejects names starting with 'voyage-' to prevent double-prefix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two bugs in the voyage handoff flow:
Handoff pointed to wrong tmux session —
armada voyage-handoff doc-chatprinted(tmux session: doc-chat)andarmada voyage attach doc-chat, but the actual session isvoyage-doc-chat. The attach command always failed. Fix:formatHandoffBlocknow prefixes session names withvoyage-for string inputs;voyage-handoffaccepts--session <name>for custom session overrides.Double-prefix possible — voyage name starting with
voyage-(e.g.voyage-foo) would produce sessionvoyage-voyage-foo. Rejected at the source byvalidateName.Tests