Repository navigation
feat: share Advanced Delivery and Lean Delivery arrangements - #2
Merged
Merged
Conversation
Owner
Author
|
The repository owner explicitly directed publication to main in the active conversation (transcript:01a097d5-01e1-7311-95a7-641419acd926: "eh apra earar na main"). All eight push/PR checks for 823ffdc passed; merging this exact reviewed head without bypassing checks. |
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved critical and moderate validator findings remain.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Publishes reusable Advanced Delivery and Lean Delivery Codex Multi-Agent V2 arrangements with optional skills, hooks, validators, documentation, and cross-platform CI.
Changes:
- Adds two 19-role arrangements with configuration caps and delegation snippets.
- Adds optional skills, spawn-contract hook, plugin guidance, and licensing notices.
- Adds validation tooling, tests, runtime evidence, installation documentation, templates, and CI.
File summaries
| File | Summary |
|---|---|
tests/test_spawn_contract.py |
Tests spawn-contract allow/deny behavior. |
tests/test_components.py |
Tests component validation. |
tests/test_catalog.py |
Tests catalog validation. |
skills/README.md |
Documents optional skills. |
skills/pragmatic-programmer/SKILL.md |
Adds pragmatic engineering skill. |
skills/pragmatic-programmer/NOTICE |
Adds skill attribution notice. |
skills/pragmatic-programmer/LICENSE |
Adds Apache-2.0 license. |
skills/codex-orchestration/SKILL.md |
Adds orchestration skill. |
skills/codex-orchestration/NOTICE |
Adds skill attribution notice. |
skills/codex-orchestration/LICENSE |
Adds Apache-2.0 license. |
scripts/validate_components.py |
Validates components. Moderate (1 vote): validate the default root .mcp.json when not overridden and add regression coverage. |
scripts/validate_catalog.py |
Validates arrangements. Critical (1 vote): reject features.multi_agent = false and add regression coverage. Critical (1 vote): detect credential filenames in quoted embedded values and test the case. Moderate (1 vote): require each arrangement README.md. |
README.md |
Provides catalog overview. |
plugins/README.md |
Documents plugin contributions and compatibility layout. |
hooks/spawn-contract/README.md |
Documents hook installation and limitations. |
hooks/spawn-contract/hooks.example.json |
Provides hook configuration example. |
hooks/spawn-contract/guard.py |
Enforces the spawn contract. |
docs/windows-sandbox.md |
Records Windows sandbox findings. |
docs/validation.md |
Documents validation scope and limitations. |
docs/runtime-evidence.json |
Stores sanitized runtime evidence. |
docs/README.pt-BR.md |
Adds Portuguese documentation. |
docs/orchestration.md |
Explains orchestration rationale and limits. |
docs/installation.md |
Documents installation and removal. |
docs/configuration.md |
Documents configuration ownership. |
docs/CHANGELOG.md |
Records the 0.1.0 release. |
CONTRIBUTING.md |
Defines contribution and validation contracts. |
arrangements/lean-delivery/README.md |
Documents Lean Delivery. |
arrangements/lean-delivery/config.toml |
Configures Lean V2 settings and caps. |
arrangements/lean-delivery/arrangement.toml |
Defines Lean arrangement metadata. |
arrangements/lean-delivery/agents/test-runner.toml |
Defines the Lean test-runner role. |
arrangements/lean-delivery/agents/test-engineer.toml |
Defines the Lean test-engineer role. |
arrangements/lean-delivery/agents/security-sweep.toml |
Defines the Lean security role. |
arrangements/lean-delivery/agents/researcher.toml |
Defines the Lean researcher role. |
arrangements/lean-delivery/agents/integrator-reviewer.toml |
Defines the Lean integration-review role. |
arrangements/lean-delivery/agents/infra-sre.toml |
Defines the Lean infrastructure role. |
arrangements/lean-delivery/agents/hard-task-specialist.toml |
Defines the Lean specialist role. |
arrangements/lean-delivery/agents/frontend-worker.toml |
Defines the Lean frontend role. |
arrangements/lean-delivery/agents/frontend-worker-light.toml |
Defines the Lean lightweight frontend role. |
arrangements/lean-delivery/agents/explorer.toml |
Defines the Lean explorer role. |
arrangements/lean-delivery/agents/docs-writer.toml |
Defines the Lean documentation role. |
arrangements/lean-delivery/agents/design-lead.toml |
Defines the Lean design role. |
arrangements/lean-delivery/agents/debugger.toml |
Defines the Lean debugger role. |
arrangements/lean-delivery/agents/database-engineer.toml |
Defines the Lean database role. |
arrangements/lean-delivery/agents/critical-reviewer.toml |
Defines the Lean critical-review role. |
arrangements/lean-delivery/agents/code-reviewer.toml |
Defines the Lean code-review role. |
arrangements/lean-delivery/agents/backend-worker.toml |
Defines the Lean backend role. |
arrangements/lean-delivery/agents/backend-worker-light.toml |
Defines the Lean lightweight backend role. |
arrangements/lean-delivery/agents/advisor.toml |
Defines the Lean advisor role. |
arrangements/lean-delivery/AGENTS.with-skill.snippet.md |
Provides Lean skill-aware instructions. |
arrangements/lean-delivery/AGENTS.snippet.md |
Provides Lean orchestration instructions. |
arrangements/advanced-delivery/README.md |
Documents Advanced Delivery. |
arrangements/advanced-delivery/config.toml |
Configures Advanced V2 settings and caps. |
arrangements/advanced-delivery/arrangement.toml |
Defines Advanced arrangement metadata. |
arrangements/advanced-delivery/agents/test-runner.toml |
Defines the Advanced test-runner role. |
arrangements/advanced-delivery/agents/test-engineer.toml |
Defines the Advanced test-engineer role. |
arrangements/advanced-delivery/agents/security-sweep.toml |
Defines the Advanced security role. |
arrangements/advanced-delivery/agents/researcher.toml |
Defines the Advanced researcher role. |
arrangements/advanced-delivery/agents/integrator-reviewer.toml |
Defines the Advanced integration-review role. |
arrangements/advanced-delivery/agents/infra-sre.toml |
Defines the Advanced infrastructure role. |
arrangements/advanced-delivery/agents/hard-task-specialist.toml |
Defines the Advanced specialist role. |
arrangements/advanced-delivery/agents/frontend-worker.toml |
Defines the Advanced frontend role. |
arrangements/advanced-delivery/agents/frontend-worker-light.toml |
Defines the Advanced lightweight frontend role. |
arrangements/advanced-delivery/agents/explorer.toml |
Defines the Advanced explorer role. |
arrangements/advanced-delivery/agents/docs-writer.toml |
Defines the Advanced documentation role. |
arrangements/advanced-delivery/agents/design-lead.toml |
Defines the Advanced design role. |
arrangements/advanced-delivery/agents/debugger.toml |
Defines the Advanced debugger role. |
arrangements/advanced-delivery/agents/database-engineer.toml |
Defines the Advanced database role. |
arrangements/advanced-delivery/agents/critical-reviewer.toml |
Defines the Advanced critical-review role. |
arrangements/advanced-delivery/agents/code-reviewer.toml |
Defines the Advanced code-review role. |
arrangements/advanced-delivery/agents/backend-worker.toml |
Defines the Advanced backend role. |
arrangements/advanced-delivery/agents/backend-worker-light.toml |
Defines the Advanced lightweight backend role. |
arrangements/advanced-delivery/agents/advisor.toml |
Defines the Advanced advisor role. |
arrangements/advanced-delivery/AGENTS.with-skill.snippet.md |
Provides Advanced skill-aware instructions. |
arrangements/advanced-delivery/AGENTS.snippet.md |
Provides Advanced orchestration instructions. |
AGENTS.md |
Defines repository maintenance guidance. |
.gitignore |
Ignores local runtime artifacts. |
.github/workflows/validate.yml |
Adds cross-platform validation CI. |
.github/pull_request_template.md |
Adds an evidence-focused PR template. |
.github/ISSUE_TEMPLATE/new-component.yml |
Adds a component issue form. |
.github/ISSUE_TEMPLATE/new-arrangement.yml |
Adds an arrangement issue form. |
.github/ISSUE_TEMPLATE/correction.yml |
Adds a correction issue form. |
.github/ISSUE_TEMPLATE/config.yml |
Configures issue-template links. |
Review details
Suppressed comments (2)
scripts/validate_catalog.py:183
- The package contract requires every
arrangements/<id>/package to includeREADME.md(CONTRIBUTING.md:43-51), but this validator checks only config, agents, and instructions references. A new arrangement can therefore pass the advertised executable contract while omitting its installation/use documentation; validate the arrangement README as a required file as well.
scripts/validate_components.py:154 - The compatibility layout is documented as allowing a root
.mcp.json(plugins/README.md:34-37), but this branch validates that file only when the manifest contains anmcpServersfield. A compatibility plugin that uses the standalone.mcp.jsonwithout that field can therefore contain malformed JSON or an escaping symlink and still pass structural preflight. Validate the default companion when the manifest does not override it, and add a regression case for that layout.
- Files reviewed: 81/82 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ( | ||
| re.compile( | ||
| r"""(?ix) | ||
| (?:^|[\\/]) |
Comment on lines
+284
to
+285
| if type(features.get("multi_agent")) is not bool: | ||
| errors.append(f"{label}: features 'multi_agent' must be a boolean") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arrangement or component and purpose
Publish a reusable community catalog of Codex Multi-Agent V2 arrangements. Advanced Delivery allocates stronger specialists to complex product work; Lean Delivery emphasizes Luna workers with one Astra critical-review role and one Sol integration-review role. Cost and quality are routing objectives, not measured guarantees.
Refs #1. Version 0.1.0 is a community preview, with runtime limitations explicitly documented rather than a claim of full certification.
Changes
codex-orchestrationandpragmatic-programmerskills, with Apache-2.0 licenses and notices; catalog, configurations and spawn-contract hook retain MIT licensing.fork_turns: "none", including the real flattened V2 tool name.Functional evidence
Windows, Codex CLI
0.155.0-alpha.3.10: the trusted hook allowed valid fresh-role delegation and blocked a disallowed fork before child creation. Selected Luna, Terra and Astra role metadata matched the intended routing. User/project configuration layers were inspected.A real native backend-worker changed a synthetic normalization fixture. The original test file's SHA-256 stayed unchanged, and the external parent reran its three-assertion behavioral test successfully. Independent native artifact review was blocked by Store PowerShell process startup in the test sandbox; CLI exit 0 is not treated as successful review. Concurrency saturation, slot release and execution of every role are not claimed. See
docs/runtime-evidence.jsonanddocs/validation.mdfor the measured boundaries.The component validator now rejects unreadable collection paths instead of reporting an empty/not-applicable result; the regression fails against the original behavior and passes after the correction. Its fixture resolves temporary-directory aliases before injecting the permission failure, so it exercises the same target on hosted Windows. Local catalog validation, structural preflight and all 37 behavioral tests pass. At commit
823ffdc, push and PR CI both passed all four Linux/Windows and Python 3.11/3.14 jobs. CI does not consume account credentials or paid model sessions.Checks