Added attributes to load dataset function#40
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds new parameters to the load_dataset function to provide more control over dataset loading behavior, including download/cache control, verification settings, parallel processing, and streaming support.
Key Changes:
- Added
download_modeparameter to control caching behavior (:reuse_dataset_if_exists,:force_redownload) - Added
verification_modeparameter to control validation checks (:basic_checks,:no_checks) - Added
num_procparameter for parallel dataset downloading and loading - Implemented streaming mode to progressively fetch data without full download
- Added comprehensive tests for all new features
- Updated documentation with examples and usage patterns
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 21 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/elixir_datasets.ex | Implemented core filtering, parallel processing, and streaming functionality for dataset loading |
| lib/huggingface/hub.ex | Added support for download_mode and verification_mode parameters in cached download logic |
| lib/elixir_datasets/utils/loader.ex | Added parallel processing support with num_proc parameter for loading datasets |
| test/elixir_datasets_test.exs | Added extensive tests for split filtering, streaming, parallel processing, and new parameters |
| test/huggingface/hub_test.exs | Added tests for download_mode and verification_mode options |
| examples/example_1.livemd | Added comprehensive documentation and examples demonstrating all new features |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Added attributes to load dataset function
New Parameters Added
🎯 Type of Changes
Remove the lines that do not apply: