perf(h3): overlap the 2-GPU recipe rollout with engine concurrency 2 - #197
Merged
Conversation
Rockdu
marked this pull request as ready for review
August 21, 2026 06:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
--sglang-server-concurrency1 → 2 in the 2-GPU MiniMax H3 t2va recipe.Why
At concurrency 1 the engine has nothing queued while a finished sample is encoded and
handed back, so it idles between denoise runs. 2 lets the next sample's denoise overlap
that handoff.
Validation
Measured on this recipe, 2x H200, identical
rollout_batch_sizexn_samples_per_prompt(2 x 8 = 16 videos per rollout), medians over 3 rollouts:
diffusion_grpo_h3_t2va_260820-205715-990diffusion_grpo_h3_t2va_260821-021535-704pre-commit run --files scripts/run_diffusion_grpo_h3_t2va_2gpu.pypasses.python3 scripts/run_diffusion_grpo_h3_t2va_2gpu.py --helpstill parses.Files
scripts/run_diffusion_grpo_h3_t2va_2gpu.pyChecklist
pre-commit run --all-filespasses — run on the touched file onlypytest -xis green — not runpython3 train.py --helpstill parses — verified on the recipe entrypoint