ci(docker): build the rollout engine from sglang's sglang-miles-h3 branch - #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Point the image's rollout engine at sglang's
sglang-miles-h3branch instead ofmain:SGLANG_DIFFUSION_BRANCH=sglang-miles-h3, plus the three places that document or mirror thatdefault (
docs/getting-started/installation.md, the install skill's prose, andsnapshot/pins.env).Why
sglang-miles-h3is upstreammainplus the diffusion RL rollouts this repo drives before theyreach
main. Today that is the MiniMax H3t2varollout (sgl-project/sglang#35598, merged): anengine built from sglang
mainstill rejects the run withMiniMax H3 does not support rollout.Split out of #154 so the image change gets its own build: #154 comes from a fork, and
pr-test.yml'sdocker-buildis guarded onhead.repo.full_name == github.repository, so a forkPR never builds the image it changes — the GPU suites there run inside the pre-change
latest.From a branch in this repo the guard passes and the Dockerfile actually gets built.
Validation
CI on this PR is the validation:
docker-pathsmatchesdocker/Dockerfile, sodocker-buildbuilds
radixark/miles_diffusion:pr-<num>fromsglang-miles-h3and every GPU suite then runsinside it.
Note
snapshot/pins.envkeepsSGLANG_COMMIT=94eef833, which is an ancestor ofsglang-miles-h3(so the install skill's ancestor check still passes) but predates the H3 rollout merge. The
snapshot wants a
refresh.shpass against the next published image; that is a separate change.