Skip to content

feat(rollout): forward --sglang-text-encoder-precisions to the engine #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Rockdu wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(rollout): forward --sglang-text-encoder-precisions to the engine #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions miles/backends/sglang_diffusion_utils/sglang_diffusion_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,12 +341,14 @@ def _compute_server_args(args, host, port, nccl_port):

if getattr(args, "use_lora", False) and getattr(args, "lora_ipc_weight_sync", False):
kwargs["lora_target_modules"] = args.lora_target_modules
# dit_precision / vae_precision are PipelineConfig fields, not ServerArgs, so forward them explicitly (only when changed from the class default, to avoid clobbering a subclass override).
# PipelineConfig fields are exposed as --sglang-* but are not ServerArgs, so the loop above skips them; forward them here, only when changed from the class default, to avoid clobbering a subclass override.
from sglang.multimodal_gen.configs.pipeline_configs.base import PipelineConfig

for field_name in ("dit_precision", "vae_precision"):
val = getattr(args, f"sglang_{field_name}", None)
if val is not None and val != getattr(PipelineConfig, field_name, None):
kwargs[field_name] = val
for field in dataclasses.fields(PipelineConfig):
if field.name in kwargs:
continue
val = getattr(args, f"sglang_{field.name}", None)
if val is not None and val != getattr(PipelineConfig, field.name, None):
kwargs[field.name] = val

return kwargs
Loading