test(verifiers): cover default rollout path - #2695
Draft
santho090 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Run the existing Verifiers training E2E through
verifiers_rollout.VerifiersRolloutFn, the shipped default, and stop forcing the legacy rollout path.Why
The sole Verifiers training E2E still selects
verifiers_rollout.generate_rolloutand setsMILES_USE_LEGACY_ROLLOUT_V1=1. Unit tests check how the launcher selects a rollout function, but they do not run the default adapter through Verifiers, SGLang, and the Miles training loop.This patch keeps the existing sample, log-probability, trainability, and reward assertions unchanged.
Validation
PYTHONPATH=. python3.11 -m pytest tests/fast/examples/experimental/verifiers/test_run.py -q --confcutdir=tests/fast/examples/experimental/verifiers: 4 passedpython3 -m py_compile tests/e2e/long/test_qwen3_0.6B_verifiers.py: passedPYTHONPATH=. python3 tests/ci/run_suite.py --hw cuda --suite stage-c-2-gpu-h200 --match-all-labels --list-only: test enableduvx --python 3.11 pre-commit run --files tests/e2e/long/test_qwen3_0.6B_verifiers.py: passedgit diff --check: passedThe 2xH200 E2E has not run on this fork. Maintainers, please approve the held CI run so the default adapter is exercised before merge.
Tracking
Closes #2560