[AMD] ci: enable the GPT-OSS 20B MoE LoRA e2e on ROCm - #2541
Draft
XinyuJiangCMU wants to merge 4 commits into
Draft
[AMD] ci: enable the GPT-OSS 20B MoE LoRA e2e on ROCm#2541XinyuJiangCMU wants to merge 4 commits into
XinyuJiangCMU wants to merge 4 commits into
Conversation
Register the existing test on the mi350 4-GPU suite and select SGLang's triton attention backend there, since aiter ships no batch-prefill kernel for this model's sink and page-size combination. Co-authored-by: Zhiyao Jiang <jessicajiang324@gmail.com>
XinyuJiangCMU
marked this pull request as draft
August 14, 2026 20:03
Register tests/fast-gpu/test_fsdp_hybrid_shard.py on the mi350 4-GPU suite. The test itself is unchanged and needs no ROCm-specific arguments. Co-authored-by: Zhiyao Jiang <jessicajiang324@gmail.com>
…lies Co-authored-by: Zhiyao Jiang <jessicajiang324@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-author-with: @JessicaJiang-123
Summary
Register
tests/e2e/megatron/model_scripts/test_gpt_oss_20b_moe_lora_ci.pyon the ROCmstage-c-4-gpu-mi350suite. The test is otherwise unchanged; both serving combinations already run as written.The one behaviour change is that ROCm selects SGLang's triton attention backend, gated on
MILES_HARDWARE_PLATFORM. ROCm otherwise defaults to aiter, which ships no compiled batch-prefill kernel for what gpt-oss-20b needs: a learned attention sink, a KV cache large enough to require the global-load variant, andpage_size=1below the kernel's tile width. That variable is only set indocker/Dockerfile.rocm, so the argument string is empty on every CUDA image and the composed args are byte-identical there. The CUDA registration is untouched.Verification
Ran the test end to end on 4x MI355X with both dependencies below applied. Each combination completed and the Ray job reported success:
collect_tests(discover_ci_files(), sanity_check=True)returns both aHWBackend.CUDAentry onstage-c-4-gpu-h200and aHWBackend.ROCMentry onstage-c-4-gpu-mi350for this file, andpre-commit runpasses.Dependencies
Merge this last; ahead of either one it turns the mi350 suite red.
docker/Dockerfile.rocminstalls it from thebridgebranch head, so the ROCm image needs a rebuild after it merges.