[peft] fix: support ROCm TE grouped-linear fields - #28
Open
Arist12 wants to merge 1 commit into
Open
Conversation
Arist12
force-pushed
the
fix/te-grouped-linear-rocm-fields
branch
from
August 13, 2026 16:29
c4b0716 to
41ce53f
Compare
Arist12
marked this pull request as ready for review
August 13, 2026 23:02
Author
|
hi @yushengsu-thu, could you help review this when you got a time? Thanks! |
Arist12
marked this pull request as draft
August 19, 2026 02:05
Arist12
marked this pull request as ready for review
August 19, 2026 23:46
Arist12
force-pushed
the
fix/te-grouped-linear-rocm-fields
branch
from
August 21, 2026 18:28
58adc8a to
3ec5b9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ROCm Transformer Engine adds
m_splits_tensor,actual_m_splits, andunpad_outputto the private grouped-linearnon_tensor_argscontract. Bridge derives the installed field order but did not provide values for those names.Change
Supply the public-wrapper defaults
None,None, andFalse. Tuple construction still selects only fields exposed by the installed TE build, so CUDA contracts that omit them are unchanged.Validation
bridge@923842f5