Skip to content

[peft] fix: support ROCm TE grouped-linear fields - #28

Open
Arist12 wants to merge 1 commit into
radixark:bridgefrom
Arist12:fix/te-grouped-linear-rocm-fields
Open

[peft] fix: support ROCm TE grouped-linear fields#28
Arist12 wants to merge 1 commit into
radixark:bridgefrom
Arist12:fix/te-grouped-linear-rocm-fields

Conversation

@Arist12

@Arist12 Arist12 commented Aug 13, 2026

Copy link
Copy Markdown

Problem

ROCm Transformer Engine adds m_splits_tensor, actual_m_splits, and unpad_output to the private grouped-linear non_tensor_args contract. Bridge derives the installed field order but did not provide values for those names.

Change

Supply the public-wrapper defaults None, None, and False. Tuple construction still selects only fields exposed by the installed TE build, so CUDA contracts that omit them are unchanged.

Validation

  • rebased onto current bridge@923842f5
  • full diff passes repository pre-commit hooks
  • focused contract test passes
  • 4x MI350X GPT-OSS LoRA completes shared-outer and per-expert layouts

@Arist12
Arist12 force-pushed the fix/te-grouped-linear-rocm-fields branch from c4b0716 to 41ce53f Compare August 13, 2026 16:29
@Arist12
Arist12 marked this pull request as ready for review August 13, 2026 23:02
@Arist12

Arist12 commented Aug 18, 2026

Copy link
Copy Markdown
Author

hi @yushengsu-thu, could you help review this when you got a time? Thanks!

@Arist12 Arist12 changed the title fix(peft): supply the ROCm TE grouped-linear fields so MoE LoRA runs on AMD [peft] fix: support ROCm TE grouped-linear fields Aug 18, 2026
@Arist12
Arist12 marked this pull request as draft August 19, 2026 02:05
@Arist12
Arist12 marked this pull request as ready for review August 19, 2026 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant