Fix creation of binary dilation structure in masking and moments tutorial#40
Closed
e-koch wants to merge 1 commit into
Closed
Fix creation of binary dilation structure in masking and moments tutorial#40e-koch wants to merge 1 commit into
e-koch wants to merge 1 commit into
Conversation
Collaborator
Author
|
Failing due to aplpy import in spectral-cube. Will need to address upstream. |
keflavich
approved these changes
Aug 5, 2024
keflavich
left a comment
keflavich
left a comment
Contributor
There was a problem hiding this comment.
might want to add some clarification of the intent of/need for the added 'swapaxes' though
Collaborator
Author
|
This was fixed at some previous point. The final comment on clarifying swapaxes in now added in #41 |
e-koch
added a commit
to e-koch/tutorials
that referenced
this pull request
Jun 30, 2025
e-koch
added a commit
that referenced
this pull request
Jun 30, 2025
* Fix creation of binary dilation structure * Update fitting folder name since it also has spatial fitting * add gitignore * fixes and co-lab install for CASA/SC guide * Update build requirements and notebook build path for page * remove aplpy install; test for notebook build failure * Remove aplpy from main requirements.txt * Unpin versions * Set min versions * typo * Build with py312; bump actions versions * Test if numpy build version error triggered by modular casa packages * Drop aplpy install next * Try preinstalling numpy * Combine build workflows to avoid future confusion on which version is running * Rename workflow * Fix branch name to trigger workflow on * Add workflow_dispatch for manually triggering CI * Remove numpy pre-install; workflow trigger fixed previous issue * Use seaborn; mpl style support was dropped in 3.8 * Fix seaborn import * Remove old workflow * Add back building the casa to sc guide * Updates to Dame outer CO arm tutorial * Fixed typo * Remove inline pip installs? * Specify package installs in the notebook * Try numpy import first? * Specify packages needed for co-lab install so the required packages are easier to determine from within the tutorial * Import numpy first; specify required packages in tutorial * Minor tweaks for cube to cube reprojection * Minor updates for reproject mask v4p1 * Minor tweaks to parallel fitting prototype example * Remove NaNs * Comment out parallel fitter for now to ensure rest of CI workflow is OK * Simplify cp * Avoid parallel fitter copy * Rename folder * Added example using astropy's builtin parallel dask fitter * Remove older version of cube-to-cube masking tutorial * Add back in build of parallel fitter * Fix yml syntax * Build is hanging likely due to dask_image; switch signal masking to scipy.ndimage * Need astropy v7 for parallel fitting functions * casa is limited to py310. try separately setting up that environment from other tutorials * Update label to be unique * Try removing quotes on py 3.10 version * Address remaining comment in #40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a small typo when applying the binary dilation operator in the final step of creating the signal mask.