fix(dtd): correct schema gaps so valid documents validate - #162
Merged
Conversation
The XSD schemas were stricter and less complete than the tooling and templates, so valid PenText documents failed XSD validation. Align the schemas with what the XSLT actually supports: - common.xsd: remove the duplicate global 'location' element. - pentestreport.xsd: make finding @Prefix optional, make <impact> optional, and allow <code> in technicaldescription, section and appendix. - offerte.xsd: add the placeholder elements the stylesheet resolves (p_draftdue, p_duration, p_location, p_participants) and allow participants, location and duration inside activityinfo. Schema-only change; every edit is a relaxation or addition, so documents that validated before still validate.
PeterMosmans
approved these changes
Jun 30, 2026
Contributor
|
Huge thanks for this @gronke - as my validation tools ran into the exact same issue(s) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The XSD schemas were stricter and less complete than the tooling and templates, so valid PenText documents failed XSD validation. Align the schemas with what the XSLT actually supports:
in technicaldescription, section and appendix.Schema-only change; every edit is a relaxation or addition, so documents that validated before still validate.