Discovery of Concurrent with ProcessPools - #90
Open
BenCarter44 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, when referencing the
ConcurrentExecutionBackendby the "concurrent" tag, it defaults to use theThreadPoolExecutor, as the constructor to theConcurrentExecutionBackendis initialized as empty.This PR allows for a user to use
concurrent:process_poolas a tag which automatically fills in theConcurrentExecutionBackendwith aProcessPoolExecutor.Reasoning: Well,
ThreadPoolExecutorhas limited performance when running cpu-intensive tasks.ProcessPoolExecutorallows the user to take advantage of multiple cores for cpu-intensive tasks. This is used specifically in the digital twin use cases where we can't / shouldn't run Dragon on different devices (eg. a Raspberry Pi).