Integrate el - #78
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the EnsembleBackend execution backend to support MPI-based distributed execution via the Ensemble Launcher framework, along with corresponding unit tests and a tutorial notebook. The review feedback highlights several robust and safety improvements for the new backend, including: preventing type confusion and cancellation issues with task["future"], handling fragile string splitting on task results, correcting a type mismatch in __all__, guarding against None from os.cpu_count(), running blocking cleanup calls in separate threads, and avoiding potential ZeroDivisionError, AttributeError, and KeyError exceptions during task building.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| ) | ||
| cpus = cpus or list(range(os.cpu_count())) | ||
| ngpus = len(gpus) if gpus is not None else 0 | ||
| gpus = gpus or [] |
There was a problem hiding this comment.
What is the difference between gpus and ngpus. A docstring would be great to express these differences.
|
Hey @harikrishna1410, thanks for the great work. Few comments (besides the Gemini caught issues/refinements):
|
2 participants
Adding a new EnsembleExecutionBackend that uses EnsembleLauncher 1. This backend provides various capabilities