explorer: plugin pages are addressable (#plugin/<endpoint>/<name>) - #116
Merged
Conversation
A plugin page could only be reached by clicking through the tree; an external page (the DT dashboard's pool titles, for one) had nothing to link to. The hash now deep-links: applied after connect (auto-connect covers the served-from-broker case), applied again on hashchange, and kept in step by showPluginPage via replaceState so the address bar always names the open page. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A plugin page could only be reached by clicking through the tree; an external page had nothing to link to — concretely, the DT dashboard's pool titles want to land on the task dispatcher's page. The hash now deep-links:
#plugin/<endpoint>/<name>is applied after connect (auto-connect covers the served-from-broker case) and on hashchange, andshowPluginPagekeeps the address bar in step viareplaceState.Verified live:
https://<broker>/#plugin/broker/task_dispatcherauto-connects and lands on the Task Dispatcher page; in-Explorer navigation updates the hash; back/forward work through the hashchange listener.(Process note: the first push of this branch was accidentally routed onto
develbypush.default=tracking— devel has been restored to7c63415by lease-pinned force push, this branch carries the commit, and the repo-local config is nowpush.default=simple.)🤖 Generated with Claude Code