packaging: ship docs/requirements.txt in the sdist - #114
Merged
Conversation
setup.py reads docs/requirements.txt for the docs extra, but MANIFEST.in did not include it - the released sdists cannot build from source (pip's wheel path hid this; conda-forge builds from the sdist and fails). MANIFEST.in now ships the file, and setup.py degrades to an empty docs extra when a source tree lacks it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
andre-merzky
added a commit
to andre-merzky/staged-recipes
that referenced
this pull request
Aug 24, 2026
0.6.0 ships docs/requirements.txt, which setup.py requires; the 0.3.0-0.5.0 sdists lacked it and failed metadata generation (radical-cybertools/radical.orbit#114). Wheel build from the 0.6.0 sdist verified locally. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The released sdists (0.3.0–0.5.0) cannot build from source:
setup.pyreadsdocs/requirements.txtfor the docs extra, butMANIFEST.innever included it (recursive-include docs *.mdonly). PyPI users never hit this because pip prefers the wheel — the conda-forge build works from the sdist and failed on every platform (staged-recipes #34581).Two-line fix:
MANIFEST.inshipsdocs/*.txt, andsetup.pydegrades to an empty docs extra when the file is absent instead of failing the whole metadata build.Verification: local
setup.py sdistfrom this branch containsdocs/requirements.txt; flake8 clean.@andre-merzky — after merge this needs a release (devel is at 0.6.0) so conda-forge can pin a buildable sdist.
🤖 Generated with Claude Code