packaging: add conda recipe (conda-forge staged-recipes candidate) - #111
Merged
Conversation
Pure-python noarch. All run deps resolve on conda-forge (msgpack -> msgpack-python, psij-python is noarch there); depends on rhapsody-py, so the rhapsody feedstock must merge first. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
Author
|
/gemini review |
1 similar comment
Member
Author
|
/gemini review |
Not noarch: setup.py templates the build interpreter's purelib path (lib/pythonX.Y/site-packages) into radical-orbit-endpoint-wrapper.sh, so one build cannot serve all python versions; build per-python with skip on <3.10 instead. doc_url pointed at a 404 (real slug has no hyphen: radicalorbit.readthedocs.io). wheel added to host to not depend on setuptools bundling bdist_wheel. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
Author
|
Local review (gemini unresponsive; Claude Code fallback, medium effort) — findings addressed in the latest commit:
Upstream flag needing a decision before the conda-forge submission: the 0.3.0 sdist's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
recipe/meta.yaml: pure-python noarch recipe pinned to the released radical-orbit 0.3.0 sdist (sha256 verified; devel's VERSION=0.4.0 is unreleased — the recipe tracks PyPI). All runtime deps resolve on conda-forge (msgpackmaps to conda'smsgpack-python; psij-python is noarch there); depends on rhapsody-py, so submission goes into one interdependent staged-recipes PR together with the rhapsody and asyncflow recipes.The authoritative copy will live in the conda-forge feedstock after staged-recipes submission; this in-repo copy is the working reference.
Verification: jinja renders and YAML parses; the sdist ships LICENSE.md, VERSION, and a pregenerated
_version.py(git-describe versioning is harmless for tarball builds).🤖 Generated with Claude Code