Demo smoke findings: list-shaped selector answers, env-resolved stream backend - #33
Merged
Merged
Conversation
- a SciAgent selector that runs as a remote function task gets its (investigator_id, model_kwargs) pair back as a JSON list -- the wire has no tuples -- and the runtime then took the whole list for the id and failed the twin with "unhashable type: 'list'". Both spellings now mean the pair. - `PubSubConfig.resolve()` ignored DT_STREAM_BACKEND, so an external producer using `ChannelPublisher.open(channel)` always opened ZMQ and could not reach an orbit-data-plane deployment. The kind now comes from the environment like everywhere else; unset stays zmq. Both found running the servicified AmSC demo (radical-collaboration/ amsc#5) against a live local broker. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016Npyz3Hbnwos12ESsdJ2YU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First live run of the servicified AmSC demo (radical-collaboration/amsc#5
run_me_service.py) against a local broker surfaced two framework bugs:Selector answers arrive as lists.
DEMO_Agentregisters its model selector as a@flow.function_task; the(investigator_id, model_kwargs)tuple comes back over the wire as a JSON list, the runtime's tuple-only check let the whole list through as the id, and the twin died withunhashable type: 'list'. The pair is now recognized in both spellings. Parametrized unit test covers tuple and list through a full agent-selection round trip.PubSubConfig.resolve()never readDT_STREAM_BACKEND. Every external producer usingChannelPublisher.open(channel)with the default config — both demo sensors — got a ZMQ backend regardless of deployment and could not reach the orbit data plane. The kind now resolves from the environment like the rest of the stack; unset stayszmq.Local: 180 unit + 30 integration passed.
🤖 Generated with Claude Code
https://claude.ai/code/session_016Npyz3Hbnwos12ESsdJ2YU