Rework for New StreamingLearnerInvestigator - #29
Draft
BenCarter44 wants to merge 2 commits into
Draft
Conversation
BenCarter44
changed the title
This was referenced Aug 27, 2026
Member
|
I know it is early, but quick question: why are we concerned about batch size on this level of abstraction? The Orbit layer is already batching requests and thus optimizing network latency impact. What is the purpose of additional higher level batching? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will fulfill issue #28 .
Here below is a draft spec of the new
StreamingLearnerInvestigator.A user simply subclasses it, and can add their own logic (and their own ROSE learner) to the callbacks. This
StreamingLearnerInvestigatorsimply provides the batch support and plumbing.Will need to be tested and cleaned up....
(Tests right now aren't expected to work, as this is a draft spec)