Fix #32: repairing minor breakage so the notebooks run again#33
Open
bruhwiler wants to merge 1 commit into
Open
Fix #32: repairing minor breakage so the notebooks run again#33bruhwiler wants to merge 1 commit into
bruhwiler wants to merge 1 commit into
Conversation
cchall
reviewed
Apr 4, 2022
cchall
left a comment
cchall
left a comment
Member
There was a problem hiding this comment.
Testing_rsbeams_decoherence runs fine for me and mostly looks alright. Though looking back at it I think I wrote this as more of a regression test. I did not document it very well for an example.
In example-NLI-construction it's probably better just to remove the code for NonlinearInsert defined in the notebook. It isn't being used and there is a link to the nonlinear module in the notebook description at the top.
If we really want to show the code in the notebook this code block be replaced with nonlinear.NonlinearInsert??
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.