Fix for socket indexing in server.c (poll code path)#181
Merged
radarsat1 merged 2 commits intoradarsat1:masterfrom Mar 12, 2026
Merged
Fix for socket indexing in server.c (poll code path)#181radarsat1 merged 2 commits intoradarsat1:masterfrom
radarsat1 merged 2 commits intoradarsat1:masterfrom
Conversation
…umbers are used to index an array of sources returning SOCKET_ERROR (-1) writes out of array bounds.
Owner
|
Look correct, good catch on multiple servers bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in which the socket index is not properly incremented when TCP servers occur earlier than the last element of a server array passed to
lo_servers_wait_internal().It also adds a check for
accept()failure.