lo_server_recv_raw_stream_socket allocation fixes#179
Merged
Conversation
Previously out of memory would leave an allocated buffer hanging.
…variable. This is just a temporary variable but it's a bit confusing to read it when it's both declared at the top and shadowed inside a loop; in the end it's not really needed, so just get rid of it.
The "again" loop logic could cause an unterminated stack allocation loop, and there was a buffer overflow risk in SLIP mode. Fixes #177.
radarsat1
force-pushed
the
lo_server_recv_raw_stream_socket-allocation-fixes
branch
from
ab5d7db to
df81f77
Compare
BriochePuppet
approved these changes
Feb 23, 2026
BriochePuppet
left a comment
BriochePuppet
left a comment
There was a problem hiding this comment.
Thanks for this patch. It looks good from my side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
various fixes for
lo_server_recv_raw_stream_socket: