Sorted for python 3#57
Open
anderspitman wants to merge 2 commits into
Open
Conversation
Need to sort dicts in order to generate deterministic test data that can be consumed by Python 3.
Merged
Contributor
|
Alternatively, the tests can do the sorting, correct, instead of changing the algorithm? |
Contributor
Author
|
@reedacartwright that could get quite involved. Not even sure how to approach it since most of the command perform multiple steps for a single output. I think the changes here are minimal enough to be worth the risk. As far as I know they don't represent any semantic change in the output, only ordering. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to generate test data that could be compared to a python 3 run of sisrs, a few changes were necessary. This mostly had to do with sorting things to make ordering deterministic. If it's decided to merge this, please look over the changes carefully to verify it won't change any important behavior or drastically affect performance or memory requirements.