Use token storage for tokens#171
Merged
Merged
Conversation
This patch updates the library to use token storage for storage, resulting in secure storage on both Android and iOS, instead of SharedPreferences and NSUserDefaults. In iOS, it's stored in the KeyChain, in Android, it's stored in DataStore but encrypted. This also updates the normal storage to be stored in DataStore. On iOS, this is a preference file in Application Support.
Contributor
Author
|
after these changes, initialization should look something like: // Android
val graph = SharedDependencyGraph.init(
driverFactory = DriverFactory(context = applicationContext),
storage = createMobileSyncStorage(applicationContext),
appEnvironment = AppEnvironment.PRELIVE,
clientId = appClientId,
clientSecret = appClientSecret
) // iOS
let storage = AppleMobileSyncStorageFactory.shared.create()
graph = SharedDependencyGraph.shared.doInit(
driverFactory: DriverFactory(),
storage: storage,
appEnvironment: AppEnvironment.prelive,
clientId: appClientId,
clientSecret: appClientSecret
) |
mohamede1945
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch updates the library to use token storage for storage,
resulting in secure storage on both Android and iOS, instead of
SharedPreferences and NSUserDefaults. In iOS, it's stored in the
KeyChain, in Android, it's stored in DataStore but encrypted.
This also updates the normal storage to be stored in DataStore. On iOS,
this is a preference file in Application Support.