-
Notifications
You must be signed in to change notification settings - Fork 13
[codex] Add SDK support for Content v4 Answers endpoints #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
basit3407
wants to merge
2
commits into
main
Choose a base branch
from
codex/v4-answers-sdk
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@quranjs/api": minor | ||
| --- | ||
|
|
||
| Add first-class SDK methods and types for the public Content v4 answers endpoints. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| import type { | ||
| AnswerCountWithinRangeResponse, | ||
| AnswerQuestion, | ||
| AnswersByAyahResponse, | ||
| BaseApiParams, | ||
| QuranFetchClient, | ||
| VerseKey, | ||
| } from "@/types"; | ||
| import { isValidVerseKey } from "@/utils"; | ||
|
|
||
| type GetAnswersByAyahOptions = BaseApiParams & { | ||
| page?: number; | ||
| pageSize?: number; | ||
| }; | ||
|
|
||
| type CountAnswersWithinRangeOptions = BaseApiParams; | ||
|
|
||
| const normalizeAnswerCountWithinRangeResponse = ( | ||
| response: AnswerCountWithinRangeResponse, | ||
| ): AnswerCountWithinRangeResponse => { | ||
| return Object.fromEntries( | ||
| Object.entries(response).map(([verseKey, count]) => { | ||
| if (!count.types) return [verseKey, count]; | ||
|
|
||
| return [ | ||
| verseKey, | ||
| { | ||
| ...count, | ||
| types: Object.fromEntries( | ||
| Object.entries(count.types).map(([type, value]) => [ | ||
| type.toUpperCase(), | ||
| value, | ||
| ]), | ||
| ), | ||
| }, | ||
| ]; | ||
| }), | ||
| ); | ||
| }; | ||
|
|
||
| /** | ||
| * Quran answers API methods. | ||
| */ | ||
| export class QuranAnswers { | ||
| constructor(private fetcher: QuranFetchClient) {} | ||
|
|
||
| /** | ||
| * Get published answer questions linked to a specific ayah. | ||
| * @param {VerseKey} key verse key in format "chapter:verse" (e.g., "2:255") | ||
| * @param {GetAnswersByAyahOptions} options | ||
| * @example | ||
| * client.answers.findByAyah("2:255", { page: 1, pageSize: 2 }) | ||
| */ | ||
| async findByAyah( | ||
| key: VerseKey, | ||
| options?: GetAnswersByAyahOptions, | ||
| ): Promise<AnswersByAyahResponse> { | ||
| if (!isValidVerseKey(key)) throw new Error("Invalid verse key"); | ||
|
|
||
| return this.fetcher.fetch<AnswersByAyahResponse>( | ||
| `/content/api/v4/answers/by_ayah/${key}`, | ||
| options, | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * Get a published answer question by id. | ||
| * @param {string | number} questionId question id | ||
| * @example | ||
| * client.answers.findByQuestionId("988") | ||
| */ | ||
| async findByQuestionId( | ||
| questionId: string | number, | ||
| ): Promise<AnswerQuestion> { | ||
| return this.fetcher.fetch<AnswerQuestion>( | ||
| `/content/api/v4/answers/${questionId}`, | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * Get a verse-key to answer-count map within an inclusive ayah range. | ||
| * @param {VerseKey} from start verse key in format "chapter:verse" | ||
| * @param {VerseKey} to end verse key in format "chapter:verse" | ||
| * @param {CountAnswersWithinRangeOptions} options | ||
| * @example | ||
| * client.answers.countWithinRange("2:255", "2:256") | ||
| */ | ||
| async countWithinRange( | ||
| from: VerseKey, | ||
| to: VerseKey, | ||
| options?: CountAnswersWithinRangeOptions, | ||
| ): Promise<AnswerCountWithinRangeResponse> { | ||
| if (!isValidVerseKey(from) || !isValidVerseKey(to)) { | ||
| throw new Error("Invalid verse key"); | ||
| } | ||
|
|
||
| const response = await this.fetcher.fetch<AnswerCountWithinRangeResponse>( | ||
| "/content/api/v4/answers/count_within_range", | ||
| { | ||
| ...options, | ||
| from, | ||
| to, | ||
| }, | ||
| ); | ||
|
|
||
| return normalizeAnswerCountWithinRangeResponse(response); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import type { VerseKey } from "../common/verse-key"; | ||
|
|
||
| export interface Answer { | ||
| id: string | number; | ||
| body: string; | ||
| answeredBy?: string; | ||
| status: string; | ||
| language?: string; | ||
| } | ||
|
|
||
| export interface AnswerQuestion { | ||
| id: string | number; | ||
| body: string; | ||
| type: string; | ||
| ranges: VerseKey[]; | ||
| surah: number; | ||
| theme?: string[]; | ||
| summary?: string; | ||
| references?: string[]; | ||
| language?: string; | ||
| status: string; | ||
| answers: Answer[]; | ||
| } | ||
|
|
||
| export interface AnswersByAyahResponse { | ||
| questions: AnswerQuestion[]; | ||
| totalCount?: number; | ||
| } | ||
|
|
||
| export interface AnswerCount { | ||
| types?: Record<string, number>; | ||
| total: number; | ||
| } | ||
|
|
||
| export type AnswerCountWithinRangeResponse = Record<string, AnswerCount>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.