Add Sentry source map uploads to webpack build#4653
Conversation
noracato
left a comment
There was a problem hiding this comment.
One check: like this the token will be included in the Docker image? Or is it just on build?
Because the image pushed to the Docker hub is public. So we should not have our auth token end up in there.
|
The sentry auth token is only needed at build time, so we do not need it in the docker image. only defined in our deployment method, I already added the following
Is worth noting that I used a existing custom internal integration auth token that we had from an earlier test because I believe it will work (based on what this page says) but the docs section of the source maps only mentions organization or personal tokens (I think the internal is simply meant to work like a personal one but for the whole organization), so we should sill make sure the permission are as follows:
*Or change it by a organization token, but in any case I do not have enough permission in Sentry. |
Description
Configure Sentry source maps so they are passed at build time to Sentry
Type of change
Checklist
Related Issues
Closes #4652