Skip to content

fix: implement fork safety guard for native handles #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fr3on merged 1 commit into from
Apr 5, 2026
Merged

fix: implement fork safety guard for native handles #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions src/Runtime/Server.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,12 @@ public function start(int $port = 8080): void
$this->spawnWorkers($nWorkers);
} else {
$this->setupSignals([]);
$this->bootWorker();
try {
$this->bootWorker();
} catch (\Throwable $e) {
fwrite(STDERR, "[Worker " . getmypid() . "] Boot failed: {$e->getMessage()}\n");
exit(1);
}
$this->runEventLoop();
}
}
Expand All @@ -87,9 +92,17 @@ private function spawnWorkers(int $nWorkers): void

if ($pid === 0) {
// ── Child process ─────────────────────────────────────────────
// Reset signal handlers inherited from parent, then boot.
$this->setupSignals([]);
$this->bootWorker();
// Block signals until Rust heap is owned by this process
pcntl_sigprocmask(SIG_BLOCK, [SIGTERM, SIGINT]);
try {
$this->setupSignals([]);
$this->bootWorker();
} catch (\Throwable $e) {
fwrite(STDERR, "[Worker " . getmypid() . "] Boot failed: {$e->getMessage()}\n");
exit(1);
}
pcntl_sigprocmask(SIG_UNBLOCK, [SIGTERM, SIGINT]);

$this->runEventLoop();
exit(0);
}
Expand All @@ -99,7 +112,16 @@ private function spawnWorkers(int $nWorkers): void

// ── Parent process ────────────────────────────────────────────────────
$this->setupSignals($pids);
$this->bootWorker();
try {
$this->bootWorker();
} catch (\Throwable $e) {
fwrite(STDERR, "[Worker " . getmypid() . "] Boot failed: {$e->getMessage()}\n");
// Kill children before exiting
foreach ($pids as $pid) {
posix_kill($pid, SIGTERM);
}
exit(1);
}
$this->runEventLoop();

// Reap any remaining children after the parent's loop exits.
Expand Down
Loading