Skip to content

fix: RateLimiter factory and initialization race condition #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fr3on merged 1 commit into from
Apr 5, 2026
Merged

fix: RateLimiter factory and initialization race condition #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/docs/middleware.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ Adds `X-Content-Type-Options`, `X-Frame-Options`, `Referrer-Policy`, and `Permis
```php
use Quill\Middleware\RateLimiter;

$app->use(new RateLimiter(maxRequests: 100, windowSeconds: 60));
$app->use(RateLimiter::withMemory(limit: 100, window: 60));
```

---
Expand Down
8 changes: 8 additions & 0 deletions src/Middleware/RateLimiter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,14 @@ public function __construct(
$this->keyResolver = $keyResolver;
}

/**
* Named factory for in-memory storage (most common).
*/
public static function withMemory(int $limit = 60, int $window = 60): self
{
return new self(new InMemoryRateLimitStorage(), $limit, $window);
}

public function __invoke(Request $request, callable $next): mixed
{
return $this->handle($request, $next);
Expand Down
Loading