feat(wallet): implement Wallet clone with atomic transfers and ledger - #32
Open
iQodeIT wants to merge 4 commits into
Open
feat(wallet): implement Wallet clone with atomic transfers and ledger#32iQodeIT wants to merge 4 commits into
iQodeIT wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Implements the Wallet clone (Bounty #6) with atomic transfers and an append-only transaction ledger.
The invariant
Satisfies the "never negative balance" and "atomic transfer" invariants. Transfers are executed within a database transaction, ensuring that a debit only happens if the balance is sufficient, and the corresponding credit and ledger entry are created atomically. Verified in
apps/api/test/wallet.test.ts.How I verified it
Ran the local probe:
Result: All transfers succeeded or failed as expected under concurrency, with final balances matching the ledger.
Checklist
pnpm -w run test)TERMS.mdAI usage (directed vs. decided):
Directed the AI to implement the Prisma schema and the Fastify routes for the wallet system, including concurrency handling using database transactions. Decided on the specific error handling and validation logic.