Skip to content

Refactor asset holdings serialization to use index-based slicing #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikemaccana merged 1 commit into from
Sep 23, 2026
Merged

Refactor asset holdings serialization to use index-based slicing #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions finance/vault-strategy/quasar/vault-strategy/src/state/strategy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@ pub const ASSET_HOLDINGS_BYTES: usize = MAX_ASSETS as usize * 8;
/// Decode `Strategy::asset_holdings` into one amount per asset index.
pub fn read_asset_holdings(bytes: &[u8; ASSET_HOLDINGS_BYTES]) -> [u64; MAX_ASSETS as usize] {
let mut holdings = [0u64; MAX_ASSETS as usize];
for (holding, chunk) in holdings.iter_mut().zip(bytes.chunks_exact(8)) {
for (index, holding) in holdings.iter_mut().enumerate() {
let start = index * 8;
let mut word = [0u8; 8];
word.copy_from_slice(chunk);
word.copy_from_slice(&bytes[start..start + 8]);
*holding = u64::from_le_bytes(word);
}
holdings
Expand All @@ -28,8 +29,9 @@ pub fn read_asset_holdings(bytes: &[u8; ASSET_HOLDINGS_BYTES]) -> [u64; MAX_ASSE
/// Encode one amount per asset index into `Strategy::asset_holdings`.
pub fn write_asset_holdings(holdings: &[u64; MAX_ASSETS as usize]) -> [u8; ASSET_HOLDINGS_BYTES] {
let mut bytes = [0u8; ASSET_HOLDINGS_BYTES];
for (chunk, holding) in bytes.chunks_exact_mut(8).zip(holdings) {
chunk.copy_from_slice(&holding.to_le_bytes());
for (index, holding) in holdings.iter().enumerate() {
let start = index * 8;
bytes[start..start + 8].copy_from_slice(&holding.to_le_bytes());
}
bytes
}
Expand Down
Loading