Repository navigation
Managed Fund: describe the confidence-interval check - #240
Merged
Merged
Conversation
The companion program now rejects a Pyth price whose confidence interval is wider than 1% of the price (OracleConfidenceTooWide, quicknode/solana-program-examples#188). The Failure Modes section describes the check and names test_wide_confidence_price_rejected in place of the sentence saying a production fund should check confidence. The valuation paragraph lists the check, the tests paragraph names the test, and the price-feed bullet no longer says withdrawal reads a price. Claude-Session: https://claude.ai/code/session_013ji7D1gLxYnd1cdd6NMXQL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The companion program now rejects a Pyth price whose confidence interval is wider than 1% of the price. The check fails with
OracleConfidenceTooWideand shipped in quicknode/solana-program-examples#188, which is merged and onmain. Following the "fixed there, not described here" rule, this PR makes the chapter describe the defense in place of the gap.Changes to
building-financial-products-in-solana/managed-fund.md:test_wide_confidence_price_rejected.OracleConfidenceTooWideandtest_wide_confidence_price_rejectedboth exist in the companion repository'smain.npm run lint,node scripts/check-figure-geometry.mjsandnpm run build-pdfall pass.🤖 Generated with Claude Code
https://claude.ai/code/session_013ji7D1gLxYnd1cdd6NMXQL
Generated by Claude Code