new release #28
new release #28
Conversation
| # Copy files from source to GitHub repo | ||
| - script: | | ||
| rsync -av --delete \ |
There was a problem hiding this comment.
Should we include the .devcontainer in case the customers want to download and try it inside a docker?
| # Create Pull Request using REST API directly | ||
| - script: | | ||
| echo "Creating Pull Request from $(SOURCE_BRANCH) to main..." |
There was a problem hiding this comment.
The default branch for KnownUser.V3.PHP is master and not main
I know that this file was written using AI (most probably GitHub Copilot), but we need to make sure it's pointing to everything correctly
| API_URL="https://api.github.com/repos/queueit/$(GITHUB_REPO_NAME)/pulls" | ||
| TITLE="Release $(SDK_VERSION)" | ||
| HEAD_BRANCH="$(SOURCE_BRANCH)" | ||
| BASE_BRANCH="main" |
There was a problem hiding this comment.
We need to change this master for the same reason in the previous comment
| @@ -0,0 +1,13 @@ | |||
| FROM php:7.3-cli | |||
There was a problem hiding this comment.
From the composer.json file on master, I can see that we are using PHP v5.3.3, but here we are using PHP 7.3 CLI. Should we use the same version (I know that this version is not on DockerHub anymore)?
What do you think?
| $composerPath = __DIR__ . '/composer.json'; | ||
| if (file_exists($composerPath)) { | ||
| $composerData = json_decode(file_get_contents($composerPath), true); |
There was a problem hiding this comment.
I think this code won't work as, or at least, will always revert back to the hardcoded version, as we don't have a version in the composer file, and I don't see any changes for that (adding the verion) in this PR.
No description provided.