Open
Conversation
…ix issues on notification handling, avoid full-document parsing
…d parantheses from word definition
emrberk
changed the title
…new suggestion on tab complete, add nano unit to highlighter
RaphDal
reviewed
Mar 25, 2026
Comment on lines
+111
to
+131
| function isCursorInComment(text: string, cursorOffset: number): boolean { | ||
| let i = 0 | ||
| const end = Math.min(cursorOffset, text.length) | ||
| while (i < end) { | ||
| const ch = text[i] | ||
| const next = text[i + 1] | ||
| // Line comment: -- until end of line | ||
| if (ch === "-" && next === "-") { | ||
| i += 2 | ||
| while (i < end && text[i] !== "\n") i++ | ||
| if (i >= cursorOffset) return true | ||
| continue | ||
| } | ||
| // Block comment: /* until */ | ||
| if (ch === "/" && next === "*") { | ||
| i += 2 | ||
| while (i < text.length && !(text[i] === "*" && text[i + 1] === "/")) i++ | ||
| if (i >= cursorOffset) return true | ||
| i += 2 // skip */ | ||
| continue | ||
| } |
There was a problem hiding this comment.
Double-quoted identifiers like "my--table" or "data/set/" causes false comment detection.
Example: SELECT AdvEngineID FROM "hits--table";
Collaborator
Author
There was a problem hiding this comment.
added the double quote check 👍
There was a problem hiding this comment.
There is still an issue with the query I provided, only the hits part get underlined in red if the table doesn't exist (maybe it's unrelated to this PR though?)
Also, there is no auto-completion on table names when in double-quotes: SELECT x FROM "hit <- nothing
src/scenes/Editor/Monaco/questdb-sql/createSchemaCompletionProvider.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.