fix(contracts): recurse hasIdFields into nested structs/arrays - #30
Open
lurrielcode wants to merge 2 commits into
Open
fix(contracts): recurse hasIdFields into nested structs/arrays#30lurrielcode wants to merge 2 commits into
lurrielcode wants to merge 2 commits into
Conversation
Fix hasIdFields to recurse into nested structs/arrays so identity converters are required when id appears only in nested fields. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
alez04
self-requested a review
August 13, 2026 23:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hasIdFieldsin the contracts generator to recurse into nested structs and arrays of structs, so identity converters are required when anidappears only in nested fields.Asset.issuerencoding viaidentityToPublicKey.Test plan
contracts.test.ts), especiallybuildQxTransferShareManagementRightsInput encodes nested Asset.issuer via identityToPublicKeybuild*TransferShareManagementRightsInput/ nested decode helper that previously used a stub converter now requires a real identity converterMade with Cursor