Skip to content

fix(docs): use one command filter for the nav and the page links #508

Open

Description

@q-soriarty

Found in the review of #505.

internal/docs/nav.go visible() drops only hidden commands, while markdown.go groupedCommands() uses IsAvailableCommand(), which also drops deprecated ones.

Failure: a command with Deprecated: set (none exists today) would get a page and a nav entry, but no link from its parent command's page.

Fix: use one predicate in both places and add a deprecated-command case to nav_test.go (and the markdown test).

Not a release blocker.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions