Fix up some logging (Quarto CLI discovery, extension host warnings) #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vezwork
approved these changes
Jan 6, 2026
Collaborator
vezwork
left a comment
vezwork
left a comment
There was a problem hiding this comment.
Approved with questions
Comment on lines
+171
to
+181
| colorTheme: workbench?.colorTheme ?? this._settings.workbench.colorTheme | ||
| }, | ||
| quarto: { | ||
| logLevel: Logger.parseLogLevel(settings.quarto.server.logLevel), | ||
| path: settings.quarto.path, | ||
| logLevel: Logger.parseLogLevel(quarto?.server?.logLevel), | ||
| path: quarto?.path ?? this._settings.quarto.path, | ||
| mathjax: { | ||
| scale: settings.quarto.mathjax.scale, | ||
| extensions: settings.quarto.mathjax.extensions | ||
| scale: quarto?.mathjax?.scale ?? this._settings.quarto.mathjax.scale, | ||
| extensions: quarto?.mathjax?.extensions ?? this._settings.quarto.mathjax.extensions | ||
| }, | ||
| symbols: { | ||
| exportToWorkspace: settings.quarto.symbols.exportToWorkspace | ||
| exportToWorkspace: quarto?.symbols?.exportToWorkspace ?? this._settings.quarto.symbols.exportToWorkspace |
Collaborator
There was a problem hiding this comment.
Nice, more defensive (less error possibilities and risk of things being undefined) and probably more correct.
Collaborator
|
Oh! P.s. I like the indentation you've done on the logs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses:
After these changes, you'll see logs like this in the Quarto output channel, depending of course on the exact details of how your Quarto is configured:
I went fairly verbose on these logs and am open to feedback about this being overkill, but I tend to think more is better, at least to some level. I did not add any of this to the status bar or anything like that; I think that the output channel is a good spot for folks to look for this kind of info.