feat(cmd): add --version flag - #59
Merged
Merged
Conversation
`--version` errored with `unknown flag` — the binary had no build-time version to print. Set cobra's rootCmd.Version (which registers --version/-v for free) from a package var, injected at release time via goreleaser ldflags. Dev builds report "dev". Matches the pattern shipped in withings-export-cli#44. New minor flag, no behavior change to any existing command. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012MvqxTC64Z9EEDewCUbNNo
Contributor
Try this PR without building itReview binaries for commit
Unzip, then on macOS/Linux Links are resolved by nightly.link, a third-party redirector for GitHub Actions artifacts, because GitHub has no anonymous artifact URL of its own. Signed-in users can also browse the run directly. Artifacts expire 14 days after the run. Updated on each push to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
liftoff-export --versionerrors withunknown flag: --version. The binary carried no build-time version string, so there was nothing to print.Change
rootCmd.Versionfrom a package varversion(default"dev"). Cobra registers--version(and-v) automatically onceVersionis non-empty — no custom subcommand.ldflags:-X …/cmd.version=v{{ .Version }}.Same pattern as quantcli/withings-export-cli#44, which is already released (v1.2.0).
Test
Manual, both paths (a build-tag injection isn't worth a unit test that would just exercise cobra):
go vet ./.../go test ./...green.🤖 Generated with Claude Code
https://claude.ai/code/session_012MvqxTC64Z9EEDewCUbNNo