Modify resample.py with safe handling of mixed dtypes#31
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## emmleroy-v1.0.0 #31 +/- ##
===================================================
+ Coverage 94.97% 96.57% +1.59%
===================================================
Files 17 17
Lines 736 846 +110
===================================================
+ Hits 699 817 +118
+ Misses 37 29 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dhhagan
left a comment
There was a problem hiding this comment.
Looks great! A few comments - can probably ignore the logging one if you're planning a separate PR for those items. The only bigger picture item is that we probably want to overhaul the file structure for this to be a bit simpler given we're moving away from a CLI-first approach to a library-first approach.
| import pandas as pd | ||
| from pandas.api.types import is_numeric_dtype | ||
|
|
||
| from ...exceptions import InvalidFileExtension |
There was a problem hiding this comment.
This isn't directly related to any changes you made, but we should probably update this notation to be proper, which in this case means something like from quantaq_cli.x.y.exceptions import InvalidFileExtension.
There was a problem hiding this comment.
Resolved for now in 8b95643 but will keep in mind for other files as well
|
Planning to convert to flatter file structure in sc-20240 |
Ports David's resampling function into resample.py