Skip to content

Modify resample.py with safe handling of mixed dtypes#31

Merged
emmleroy merged 8 commits into
emmleroy-v1.0.0from
emmleroy-sc-20239-modify-resample
Jun 30, 2026
Merged

Modify resample.py with safe handling of mixed dtypes#31
emmleroy merged 8 commits into
emmleroy-v1.0.0from
emmleroy-sc-20239-modify-resample

Conversation

@emmleroy

Copy link
Copy Markdown

Ports David's resampling function into resample.py

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.35897% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.57%. Comparing base (a876d71) to head (8b95643).
⚠️ Report is 1 commits behind head on emmleroy-v1.0.0.

Files with missing lines Patch % Lines
quantaq_cli/console/commands/resample.py 98.41% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           emmleroy-v1.0.0      #31      +/-   ##
===================================================
+ Coverage            94.97%   96.57%   +1.59%     
===================================================
  Files                   17       17              
  Lines                  736      846     +110     
===================================================
+ Hits                   699      817     +118     
+ Misses                  37       29       -8     
Flag Coverage Δ
unittests 96.57% <99.35%> (+1.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
quantaq_cli/console/__init__.py 98.68% <100.00%> (+0.05%) ⬆️
quantaq_cli/utilities.py 80.00% <100.00%> (+1.05%) ⬆️
tests/test_merge.py 100.00% <100.00%> (ø)
tests/test_resample.py 100.00% <100.00%> (ø)
quantaq_cli/console/commands/resample.py 96.20% <98.41%> (+25.14%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dhhagan dhhagan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A few comments - can probably ignore the logging one if you're planning a separate PR for those items. The only bigger picture item is that we probably want to overhaul the file structure for this to be a bit simpler given we're moving away from a CLI-first approach to a library-first approach.

import pandas as pd
from pandas.api.types import is_numeric_dtype

from ...exceptions import InvalidFileExtension

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't directly related to any changes you made, but we should probably update this notation to be proper, which in this case means something like from quantaq_cli.x.y.exceptions import InvalidFileExtension.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved for now in 8b95643 but will keep in mind for other files as well

Comment thread quantaq_cli/console/commands/resample.py
Comment thread quantaq_cli/console/commands/resample.py
Comment thread tests/test_resample.py
Comment thread quantaq_cli/console/__init__.py
@emmleroy

Copy link
Copy Markdown
Author

Planning to convert to flatter file structure in sc-20240

@emmleroy emmleroy merged commit 9235f1a into emmleroy-v1.0.0 Jun 30, 2026
8 checks passed
@emmleroy emmleroy deleted the emmleroy-sc-20239-modify-resample branch June 30, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants