feat(terminal): configurable shell for bash tool (port upstream PR #260)#303
Merged
Conversation
Port of upstream PR 1jehuang#260 (open). Lets users on nu / zsh / fish / pwsh have agent-spawned bash tool calls run through their preferred shell instead of the platform default. Config: [terminal] shell = 'nu' # or 'zsh', 'fish', 'pwsh', '/bin/dash' Env override: JCODE_SHELL=zsh Behavior: - shell unset → platform default (bash on Unix, cmd.exe on Windows) preserves existing behavior - shell set → spawn the named binary with '-c <command>' - shell name resolved via PATH; absolute paths supported Caveats (intentionally same as upstream): - Most shells accept '-c'; nu, zsh, bash, sh, fish (in some modes), pwsh (with '-Command' which we approximate via -c) - PowerShell users wanting full pwsh syntax should still wrap commands in 'pwsh -Command "..."' inside the agent prompt. Refs upstream PR 1jehuang#260.
quangdang46
added a commit
that referenced
this pull request
May 24, 2026
After merging 13 PRs in sequence (#290 + #292-#303), two squash-merges collided on shared schema state: 1. crates/jcode-provider-metadata/src/catalog.rs: - Both VERTEX_AI (#283, prior) and BIGMODEL (#297) added entries. - Both #19 (#263 GitLab Duo, prior) and #297 declared array size, each thinking they were +1 from baseline. Net actual: +2 from baseline but final declared count was off by 1. - Fixed: OPENAI_COMPAT_PROFILES 35→36, LOGIN_PROVIDERS 48→49 to match actual entry count. 2. src/cli/commands/provider_setup.rs: - PR #299 added headers: BTreeMap<String, String> field to NamedProviderConfig but didn't update this constructor (which pre-dated #299 in master). - Fixed: added headers: BTreeMap::new() in the configure constructor. cargo check -p jcode --bin jcode now clean. No behavioral change beyond what each PR brought.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of upstream PR 1jehuang/jcode#260 (open). Lets users on
nu/zsh/fish/pwshhave agent-spawned bash tool calls run through their preferred shell.Behavior
shellunset → platform default (bashon Unix,cmd.exeon Windows) — preserves existing behaviorshellset → spawn named binary with-c <command>Caveats
PowerShell users wanting full
pwshsyntax should still wrap commands inpwsh -Command \"...\"inside the agent prompt.Refs upstream PR 1jehuang/jcode#260.